Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lenient loading and type system merging to load_cas_from_json #288

Merged
merged 3 commits into from
Oct 4, 2023

Conversation

timbmg
Copy link
Contributor

@timbmg timbmg commented May 3, 2023

  • Add lenient loading parameter when loading CAS from JSON
  • Add merge_typesystem parameter when loading CAS from JSON

@reckart reckart added this to the 0.7.7 milestone Oct 4, 2023
@reckart reckart changed the title Add lenient Parameter to load_cas_from_json Add lenient loading and type system merging to load_cas_from_json Oct 4, 2023
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #288 (7968342) into main (ed6b4f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #288   +/-   ##
=======================================
  Coverage   95.11%   95.11%           
=======================================
  Files           5        5           
  Lines        1966     1967    +1     
=======================================
+ Hits         1870     1871    +1     
  Misses         96       96           
Files Coverage Δ
cassis/json.py 90.35% <100.00%> (+0.02%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@reckart reckart merged commit 0b7a40f into dkpro:main Oct 4, 2023
7 checks passed
@reckart
Copy link
Member

reckart commented Oct 4, 2023

@timbmg Thanks for the contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants